1
0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-10 18:07:59 +00:00
Commit Graph

2784 Commits

Author SHA1 Message Date
Simon Tatham
6df09c6275 <1112163342.018492.101240@f14g2000cwb.googlegroups.com> on
comp.security.ssh contains a Dr Watson log which looks to me as if
`unclean-close-crash' occurred due to a rekey timer going off after
the session had closed. Hence, ssh2_timer() now avoids doing
anything if the session is already closed, and also ssh_do_close()
proactively calls expire_timer_context(). Between those I think they
ought to solve the problem.

[originally from svn r5564]
2005-03-30 08:27:54 +00:00
Simon Tatham
a34ab9bfc9 Small markup fixes I just noticed, mostly use of literal double
quotes where \q{} would be better.

[originally from svn r5562]
2005-03-29 14:24:14 +00:00
Simon Tatham
4fa2049108 After we receive EOF on stdin, we should clear ssh->send_ok so that
we stop trying to read anything further from stdin. Otherwise we
send a continuous stream of SSH2_MSG_CHANNEL_EOF.

[originally from svn r5561]
2005-03-29 13:10:33 +00:00
Simon Tatham
d0beed9aba Render timing.c robust in the face of strangeness. The strangenesses
in question vary per OS: on Windows the problem is that WM_TIMER
sometimes goes off too early, so that GetTickCount() is right and
the callback time is wrong, whereas on Unix the problem is that my
GETTICKCOUNT implementation comes from the system clock which means
it can change suddenly and non-monotonically if the sysadmin is
messing about (meaning that the timing of callbacks from GTK or
select timeouts is _more_ likely to be right than GETTICKCOUNT).
This checkin provides band-aid workarounds for both problems, which
aren't pretty but ought to at least prevent catastrophic assertion
failure.

[originally from svn r5556]
2005-03-28 17:48:24 +00:00
Jacob Nevins
2daa1b737c In fact, I'll document the wrinkle with "plink -load", rather than just
wittering about it on a mailing list.

[originally from svn r5550]
2005-03-24 02:22:21 +00:00
Jacob Nevins
aac9b209a0 Fix comment re dmemdumpl()
[originally from svn r5549]
2005-03-24 01:01:24 +00:00
Jacob Nevins
2d379524c3 Since Markus Kuhn no longer explicitly places wcwidth.c in the public domain,
it'd probably be generous to list him in the copyrights.

[originally from svn r5548]
[this svn revision also touched putty-website]
2005-03-23 20:23:07 +00:00
Jacob Nevins
9049f43955 `wcwidth-upgrade': upgrade to latest wcwidth.c from Markus Kuhn
<http://www.cl.cam.ac.uk/~mgk25/ucs/wcwidth.c>.
This is identified both internally and in HTTP headers as 2003-05-20,
for Unicode 4.0.

Only changes from upstream are to make mk_wcwidth_cjk() non-static and to
#include "putty.h" for prototypes.

The status of some code points has changed; see the wishlist item. We've
had some feedback from the CJK and Arabic communities that upgrading is
probably the right thing to do.

[originally from svn r5547]
[this svn revision also touched putty-wishlist]
2005-03-23 20:04:08 +00:00
Jacob Nevins
cb779c95e3 Another fix from Hung-Te Lin; apparently in some IMEs (such as
"MS NewPhonetics"), move events (arrow keys) were being doubled up,
apparently because we turned both KEYDOWN and KEYUP events into new
KEYDOWN events.

I don't claim to understand the precise effect of this patch :( but
I'm reasonably confident that it only affects IME users, and experimentally
it doesn't seem to break anything obvious, so if piaip says it makes
things better that's good enough for me :)

[originally from svn r5545]
2005-03-23 01:08:18 +00:00
Jacob Nevins
ddb1fc1256 Fix my fix (r5539) to the `multi-changesettings-crash' fix. Ahem.
[originally from svn r5543]
[r5539 == 5b695d81ad]
2005-03-22 23:25:21 +00:00
Jacob Nevins
faf59c78be Add an option to use wcwidth_cjk() instead of wcwidth(), as several people
have asked for it.

[originally from svn r5542]
2005-03-22 23:20:23 +00:00
Jacob Nevins
5b695d81ad Hung-Te Lin spotted that the `multi-changesettings-crash' workaround for Windows
would prevent a user opening Change Settings if they'd cancelled a previous
Change Settings.

[originally from svn r5539]
2005-03-21 22:20:22 +00:00
Jacob Nevins
dcc4ffbd34 Mention PUTTY.RND by name
[originally from svn r5538]
2005-03-21 17:43:59 +00:00
Simon Tatham
7e715c5aaf Martin Trautmann spotted a bare char being passed to isspace.
[originally from svn r5536]
2005-03-21 13:46:16 +00:00
Jacob Nevins
deadab0900 Trim application manifests as much as MS' documentation and Owen's experiments
on XP allow while still having the desired effect -- this allows removal of
some fibs.
Also, change version number to 0.0.0.0 in preparation for `win-versioninfo'
(not that we found anything that took any notice of the version number 
declared here).

[originally from svn r5534]
2005-03-21 01:51:22 +00:00
Jacob Nevins
091462f240 Improvement for IME font display from Hung-Te Lin.
Not tested, but it appears only to affect Glenn Maynard's r1406 code from
<20011006170741.A23470@zewt.org> and nothing else, so seems harmless enough.

[originally from svn r5533]
[r1406 == d9f7fc44bc]
2005-03-21 01:05:38 +00:00
Jacob Nevins
bcd70d0661 Add comments about default processing in DialogProc/WindowProc, since I
often forget the rules.

[originally from svn r5532]
2005-03-20 22:28:13 +00:00
Ben Harris
616f220472 Revert last change: Some versions of the GNU C Library (notably SUSE
glibc-2.3.3-118 and Debian libc6 2.3.2.ds1-20) have clock_gettime() and
CLOCK_MONOTONIC in their headers, but not in libc itself, which we can't
detect easily.

[originally from svn r5529]
2005-03-19 19:23:49 +00:00
Ben Harris
f812865ceb If it's available, try to use clock_gettime(CLOCK_MONOTONIC) rather than
gettimeofday(), since the former shouldn't warp when the user resets the clock.

[originally from svn r5528]
2005-03-19 19:02:53 +00:00
Simon Tatham
68d88605ae Work around lcc's annoying (but, even more annoyingly, legitimate)
refusal to allow comparison of function pointers. Unfortunately this
still doesn't cause PuTTY to compile on my lcc installation, because
the GetCharacterPlacement stuff in exact_textout() is missing from
its header files. This may have been fixed in a future version (I'm
using lcc-win32 version 3.8 from December 2003), but I haven't
checked.

[originally from svn r5527]
2005-03-19 16:34:58 +00:00
Jacob Nevins
cacf8fcc3d More compact display for the key links/fingerprints. Still not ideal, but
it'll probably do.

[originally from svn r5526]
2005-03-19 03:05:44 +00:00
Jacob Nevins
36fc6c0a76 Try to make our PGP signing more useful:
* All the PuTTY tools for Windows and Unix now contain the fingerprints of
   the Master Keys. The method for accessing them is crude but universal:
   a new "-pgpfp" command-line option. (Except Unix PuTTYgen, which takes
   "--pgpfp" just to be awkward.)

 * Move the key policy discussion from putty-website/keys.html to
   putty/doc/pgpkeys.but, and autogenerate the former from the latter.
   Also tweak the text somewhat and include the fingerprints of the
   Master Keys themselves.
   (I've merged the existing autogeneration scripts into a single new
   one; I've left the old scripts and keys.html around until such time
   as the webmonster reviews the changes and plumbs in the new script;
   he should remove the old files then.)

[originally from svn r5524]
[this svn revision also touched putty-website]
2005-03-19 02:26:58 +00:00
Simon Tatham
82f82fdb6d After we thaw a frozen socket, we apparently need to restart the
WSAAsyncSelect or else Windows loses read events.

[originally from svn r5521]
2005-03-18 19:47:21 +00:00
Jacob Nevins
5eb26fa459 I believe MAC/CRC errors can be caused by network corruption, in principle.
[originally from svn r5520]
2005-03-18 12:58:39 +00:00
Simon Tatham
0a4181d396 Hung-Te Lin's fix for intermittent WM_PAINT problems.
[originally from svn r5518]
2005-03-17 20:01:28 +00:00
Simon Tatham
7e41c571db The structural reorganisation of ssh.c (r4909) caused
ssh2_try_send() to no longer be run after receiving WINDOW_ADJUSTs.
I believe this is likely to have been the cause of recent PSCP
hanging issues.

[originally from svn r5517]
[r4909 == 02b0474f57]
2005-03-17 19:49:51 +00:00
Jacob Nevins
69209db8ea faq-savedsettings: mention Default Settings
[originally from svn r5514]
2005-03-16 16:09:44 +00:00
Simon Tatham
780ca62311 Fix `telnet-option-loop', I think. (Untested except to check it
compiles, since I don't have a suitably awkward server to run it
against; but Ben reviewed the patch before checkin so we can share
the blame if it doesn't work.)

[originally from svn r5512]
[this svn revision also touched putty-wishlist]
2005-03-16 13:20:02 +00:00
Owen Dunn
1e21ea8f63 Add protection against multiple Change Settings dialogues.
[originally from svn r5508]
2005-03-15 20:34:08 +00:00
Owen Dunn
e4520ee6c7 Fix pterm-logtype-crash
[originally from svn r5505]
2005-03-15 10:43:29 +00:00
Jacob Nevins
b36d32b881 Consistent indenting in option specs
[originally from svn r5502]
2005-03-14 01:56:39 +00:00
Jacob Nevins
e4a5884636 punctuation nit
[originally from svn r5495]
2005-03-11 21:05:12 +00:00
Jacob Nevins
492b3933f8 Retire MINGW32_FIX. It was a fix for a blatant bug in MinGW's windres, which
was fixed in CVS in 2000 (I think); and we now depend on MinGW much more
recent than that for various other reasons. I've tested with my current
MinGW (around 2.0.0 vintage) and the original symptoms (dodgy characters in
edit boxes) don't appear to show up.

[originally from svn r5491]
2005-03-11 15:52:59 +00:00
Jacob Nevins
1ddb28955c Make it clearer which protocol version various bugs apply to.
[originally from svn r5490]
2005-03-11 15:24:09 +00:00
Simon Tatham
ab659aac49 Fiddle with source archive for new OS X files.
[originally from svn r5489]
2005-03-11 09:07:37 +00:00
Simon Tatham
a1f0e69fe4 Thanks to D H Becker for sending in an icon. I'd have liked to have
written a script which would generate the various graphical
components of the PuTTY icon suite at any given resolution and then
used that to generate the OS X icon as well as all the others, but I
can always do that later; this'll do for now.

[originally from svn r5487]
2005-03-10 20:11:27 +00:00
Ben Harris
7726a0c49c Expand "v" to "version" when discussing SSH protocol versions.
[originally from svn r5486]
2005-03-10 17:08:37 +00:00
Ben Harris
d970e2fb5e When we're quoting user-interface text from PuTTY 0.51, we probably shouldn't
correct its spelling of "SSH-2".

[originally from svn r5485]
2005-03-10 17:08:00 +00:00
Ben Harris
6b9766a575 Fix an "SSH v1" that Jacob missed (because it spanned a line break).
[originally from svn r5484]
2005-03-10 17:06:29 +00:00
Ben Harris
6070903a09 Make it clear that even when using SSH 2, you only need the SSH-2 pubkey format
if you're actually using the SSH-2 protocol.

[originally from svn r5483]
2005-03-10 17:04:26 +00:00
Jacob Nevins
5aa719d16e Consistently use a single notation to refer to SSH protocol versions, as
discussed. Use Barrett and Silverman's convention of "SSH-1" for SSH protocol
version 1 and "SSH-2" for protocol 2 ("SSH1"/"SSH2" refer to ssh.com
implementations in this scheme). <http://www.snailbook.com/terms.html>

[originally from svn r5480]
2005-03-10 16:36:05 +00:00
Simon Tatham
dfccca7974 Support multiple anchor name types now that Jacob has enhanced
Halibut to be able to do so.

[originally from svn r5479]
2005-03-10 16:18:51 +00:00
Owen Dunn
c7e71fe2ec Protect against multiple Change Settings dialogues. We should probably also
arrange to switch to an existing Change Settings if the user selects the
menu item and we already have a Change Settings.

[originally from svn r5475]
2005-03-10 10:07:27 +00:00
Jacob Nevins
cb47941b61 Ben Hutchings reports that new PuTTY instances created from the saved
sessions menu (etc) can inherit listening sockets, and that this sometimes
causes trouble. Can't reproduce any problems myself, but let's only allow
inheritance when absolutely necessary -- Duplicate Session -- in which
case there's already going to be trouble with two processes trying to
listen on the same port.

[originally from svn r5468]
2005-03-08 23:06:15 +00:00
Jacob Nevins
470bdd13ea Miscellaneous tweaks.
[originally from svn r5461]
2005-03-08 14:20:38 +00:00
Simon Tatham
89e5b32237 Charlie at work points out that the screen FAQ contains a different
- and probably better - solution to the screen-vs-alt-screen issue.
Reference it and describe the fix.

[originally from svn r5452]
2005-03-07 16:40:11 +00:00
Simon Tatham
b3d4ecd345 `What commands can I type into my PuTTY session' is probably the
single most frequently asked thing which isn't in the FAQ (it's in
feedback.but instead), so let's add it. I'm uncertain that the
people who mail us asking things like `how do I read my email' and
`how do I access $database' will successfully recognise this more
general question as one which includes their specific one, but it's
worth a try.

[originally from svn r5451]
2005-03-07 14:07:19 +00:00
Jacob Nevins
b222632c66 Add notification when using the various auth methods with server-supplied
prompts, to make it more obvious if a server is attempting to spoof a local
passphrase prompt.

I believe an alert user could have spotted this in all cases in SSH-2,
although perhaps not in SSH-1. (But they'd have to have enabled
TIS/CryptoCard.)

[originally from svn r5450]
2005-03-06 16:38:19 +00:00
Jacob Nevins
d860adb55d Fix sense of test in previous checkin :)
[originally from svn r5448]
2005-03-06 15:00:45 +00:00
Simon Tatham
be8acb5615 I'm sick and tired of the persistent reports of lineptr() failing
its `line != NULL' assertion, so I've replaced the assertion with a
call to fatalbox() giving oodles of information. I may still not be
able to reproduce it, but at least next time it happens we should
see a decent amount of debugging data!

[originally from svn r5447]
2005-03-06 14:48:22 +00:00