1
0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-10 18:07:59 +00:00
Commit Graph

1309 Commits

Author SHA1 Message Date
Ben Harris
454e6d2a43 Remove more unused variables.
[originally from svn r2372]
2002-12-28 22:25:31 +00:00
Ben Harris
1cfe88e9d2 Dispose of some unused local variables.
[originally from svn r2371]
2002-12-28 22:22:43 +00:00
Ben Harris
ee01ff5731 The current version of SC generates warnings for unused parameters just
like MrC.  Turn them off, since they're clearly silly.

[originally from svn r2370]
2002-12-28 22:17:51 +00:00
Simon Tatham
b2f4de02b9 Mention in the documentation that the method of generating RSA keys
might give a bit count one less than the one the user asked for. Two
people have been worried by this now, and it's probably worth
documenting that it's perfectly normal.

[originally from svn r2369]
2002-12-27 16:54:14 +00:00
Simon Tatham
6c34f06a71 Move the stderr output of event log messages in verbose mode to the
general logging module rather than localising it in ssh.c. This
means it should work in other protocols as well (notably Telnet,
where it might actually be useful for debugging negotiations).

[originally from svn r2360]
2002-12-19 14:24:28 +00:00
Simon Tatham
6adef8429a First crack at an implementation of TELOPT_BINARY, which apparently
RFC 1123 (host requirements) says is compulsory.

[originally from svn r2358]
2002-12-19 14:22:16 +00:00
Simon Tatham
7f7e3f539c logeventf() shouldn't throw stuff at stderr, since it invokes the
ssh.c logevent _macro_ which has already done so! Duhh.

[originally from svn r2356]
2002-12-19 11:51:42 +00:00
Simon Tatham
a564ad3140 Support for doing DNS at the proxy end. I've invented a new type of
SockAddr, which just contains an unresolved hostname and is created
by a stub function in *net.c. It's an error to pass this to most of
the real-meat functions in *net.c; these fake addresses should have
been dealt with by the time they get down that far. proxy.c now
contains name_lookup(), a wrapper on sk_namelookup() which decides
whether or not to do real DNS, and the individual proxy
implementations each deal sensibly with being handed an unresolved
address and avoid ever passing one down to *net.c.

[originally from svn r2353]
2002-12-18 16:23:11 +00:00
Simon Tatham
e1cc16e6be Better reporting of DNS errors while trying to find the proxy server.
[originally from svn r2350]
2002-12-18 12:32:18 +00:00
Simon Tatham
8304f4e0dc Stop proxying connections to localhost by default; should fix
`x11-proxy-crash'.

[originally from svn r2348]
2002-12-18 12:18:54 +00:00
Simon Tatham
c583c6e85e Placate a trivial compiler warning.
[originally from svn r2347]
2002-12-18 11:51:09 +00:00
Simon Tatham
297e5d8e45 Improve the tab order in the Tunnels box: the `Add' button should
happen _after_ all the controls that set up the forwarding, since
that's the obvious order you'd want to use them in.

[originally from svn r2346]
2002-12-18 11:49:14 +00:00
Simon Tatham
99b870dbc6 Implement `portfwd-loopback-choice'. Works on local side in Unix as
well, though it's a lot less useful since you still can't bind to
low-numbered ports of odd loopback IPs. Should work in principle for
SSH2 remote forwardings as well as local ones, but OpenSSH seems
unwilling to cooperate.

[originally from svn r2344]
2002-12-18 11:39:25 +00:00
Simon Tatham
8cb52a26e1 BUG_SSH2_DERIVEKEY is apparently only present in SSH 2.0.11 and
before, not in 2.0.13. Verified on at least one host. Fixes bug
`ssh2-keyderive-nonbug'.

[originally from svn r2342]
2002-12-18 10:06:38 +00:00
Simon Tatham
801832bf59 `Leonid' points out a stupid mistake in MD5 HMAC initialisation: we
should initialise _both_ MD5 states, not the same one twice.

[originally from svn r2341]
2002-12-18 09:54:55 +00:00
Simon Tatham
29b0705961 logeventf()'s first argument is ssh, not ssh->frontend! This is what
I get for making the latter a `void *' - type checking deserts me in
my hour of need. Should fix Andrey Borzenkov's bug.

[originally from svn r2340]
2002-12-18 09:47:20 +00:00
Jacob Nevins
368ee4856b Fixing trivial warnings spotted by Mingw-2.0.0/gcc-3.2:
window.c:90: warning: `do_mouse_wheel_msg' declared `static' but never defined
Introduced in 1.185 [r1499]. This function doesn't appear to ever have
existed.

[originally from svn r2334]
[r1499 == d6016149bf]
2002-12-15 13:31:58 +00:00
Jacob Nevins
c399f8381f Fixing trivial warnings spotted by Mingw-2.0.0/gcc-3.2:
psftp.c: In function `sftp_cmd_chmod':
  psftp.c:835: warning: too many arguments for format

[originally from svn r2333]
2002-12-15 13:25:24 +00:00
Jacob Nevins
6f5012dfa6 Fixing trivial warnings spotted by Mingw-2.0.0/gcc-3.2:
plink.c:65: warning: `password' defined but not used
(introduced in 1.50 [r1525])

[originally from svn r2332]
[r1525 == 466b1c82d5]
2002-12-15 13:23:13 +00:00
Jacob Nevins
e891f79c12 Fixing trivial warnings spotted by Mingw-2.0.0/gcc-3.2:
plink.c: In function `from_backend':
  plink.c:172: warning: unused variable `h'
(introduced in 1.35 [r1198])

[originally from svn r2331]
[r1198 == c87fa98d09]
2002-12-15 13:19:59 +00:00
Jacob Nevins
414b896aaf From Greg Prosser: Apparently using "MS Shell Dlg" instead of "MS Sans Serif"
in resource files interoperates better with WinXP (enabling font smoothing
and improving display of password boxes). I've verified that it's harmless
on Win95.

[originally from svn r2329]
2002-12-15 12:44:21 +00:00
Jacob Nevins
23a2fb17d8 faq-rh8-utf8: Problems with Red Hat 8.0 and UTF-8
[originally from svn r2327]
2002-12-15 11:51:21 +00:00
Ben Harris
875d7c351e Remove an unnecessary "{Includes}" from the example Rez command.
[originally from svn r2317]
2002-12-13 00:50:53 +00:00
Ben Harris
8abe8187f7 Provide a full set of small application icons for PuTTY, now equipped with
small lightning flashes too.

[originally from svn r2316]
2002-12-13 00:45:08 +00:00
Ben Harris
93f12a008d Use the Unicode Converter to convert from Unicode to the display encoding
if it's available.  Linking against the static Unicode Converter library
costs us about 30k on Classic 68K, which I can live with.

Because the default fallback converter can generate multiple output
characters for a single input character, we provide our own fallback that
doesn't.  It converts everything to '?' instead.

[originally from svn r2315]
2002-12-13 00:02:48 +00:00
Ben Harris
c6bbb682a3 When loading a string setting, expect in the same form we would have
saved (raw text rather than Pascal string).

[originally from svn r2314]
2002-12-12 23:55:51 +00:00
Ben Harris
5b4947e590 Add some documentation for the Mac port.
[originally from svn r2305]
2002-12-11 18:34:49 +00:00
Jacob Nevins
93c1b22f0d IPv4/IPv6 sense problem in SOCKS5 proxying spotted by Andrey Borzenkov --
recent change.

[originally from svn r2301]
2002-12-10 10:19:51 +00:00
Ben Harris
8ff26fd9e5 Since PuTTY depends on lots of features of System 7, have it bale out if
it finds itself running on anything older.  This is better than killing the
whole system with an umimplemented trap.

[originally from svn r2300]
2002-12-10 01:11:40 +00:00
Ben Harris
d78a0aacc0 When resizing the window, redraw the grow box as well as the scroll bar.
I wasn't noticing the bug on my system, since the Appearance Manager handles
the grow box itself when it's present.

[originally from svn r2299]
2002-12-09 23:26:52 +00:00
Ben Harris
05456758c4 Update the non-Color Quickdraw code in pre_paint() to match recent changes
to the Color Quickdraw code.  This makes redraw work properly on old Macs
again.

[originally from svn r2298]
2002-12-09 22:49:56 +00:00
Ben Harris
e06e554830 Oops. When deciding which attributes are interesting, we want the union of
all the screens' capabilites, not the intersection.

[originally from svn r2297]
2002-12-08 22:23:08 +00:00
Ben Harris
65b8dd1501 Remove a stray prototype for mac_set_attr_mask().
[originally from svn r2296]
2002-12-08 22:15:10 +00:00
Ben Harris
c76391bccb Remove some unused cruft.
[originally from svn r2295]
2002-12-08 22:09:47 +00:00
Jacob Nevins
4ffd0ca9d1 Modify bug-compatibility checks to use wildcards. Should have exactly the
same behaviour as before (tested a little bit), but should be easier to
expand.
(This is the easy bit -- work still needs to be done to fix
ssh2-keyderive-nonbug, vshell-no-bug-compat, etc -- but should be easier
now.)

[originally from svn r2293]
2002-12-08 16:54:31 +00:00
Jacob Nevins
5d20178a12 Wrong length was causing spurious \0 to be sent during SSH negotiation with
HTTP proxy -- fixed. (Also added a "len -= eol" to HTTP header munching,
although it has no practical effect.) HTTP proxying now works again, hurrah.

[originally from svn r2292]
2002-12-08 15:32:40 +00:00
Jacob Nevins
b3f2c9475e Argh. With DEBUG and MALLOC_LOG enabled, I found output intended for the
console was ending up in one or other of debug.log or putty_mem.log. I
don't really understand why, but I've put some extra paranoia and caching
in debug(()) and that seems to have fixed it (tm). Perhaps I can get back
to debugging...

[originally from svn r2291]
2002-12-08 14:44:42 +00:00
Jacob Nevins
242a4872b9 Doofus Award: logfopen is shared between SSH-packet and session-logging modes,
so of _course_ it has to be mode "wb". Restored, and added \r to all of the
SSH packet logging stuff.

[originally from svn r2289]
2002-12-08 12:10:58 +00:00
Simon Tatham
3bb2e4568c Add a new diagnostic in winnet.c, to attempt to pinpoint the reason
for the tree234 assertion failure we've had reported recently.

[originally from svn r2288]
2002-12-08 11:00:47 +00:00
Ben Harris
7522f5302d Slightly cheesy size-tip implementation. This is suboptimal in two ways:
* It paints over the top-left corner of the terminal window.  A little
   floating window would be rather nicer and not much harder to do.
 * It uses the low-memory global, DragHook, which is unavailable in Carbon
   and broken in some versions of Mac OS 8 (8.5?).  I suspect this is
   unavoidable, though.

[originally from svn r2287]
2002-12-08 01:17:31 +00:00
Jacob Nevins
9ee5d85169 For some reason Roman Pompejus' original logging patch opened the log in
"wb" mode. Since we were mostly writing "\n" rather than "\r\n", I've
changed it to just "w" and refunded the difference.

[originally from svn r2286]
2002-12-07 21:35:05 +00:00
Jacob Nevins
602834d887 Fix write to freed memory in HTTP proxying. Things aren't entirely happy yet,
though.

[originally from svn r2285]
2002-12-07 21:15:49 +00:00
Ben Harris
f2bfdefe45 When scrolling part of the window, scroll the update region as well so that
parts that haven't been painted yet still get an update event in their new
location.  This code seems far too complicated, and I suspect there's a
better way.  Still, scrolling continuously with the window partially
off-screen now works.

[originally from svn r2284]
2002-12-07 15:21:56 +00:00
Jacob Nevins
64bbf0d4f2 Ignore generated Mac Makefile
[originally from svn r2283]
2002-12-07 12:03:33 +00:00
Ben Harris
7c308678e4 Use the Script Manager to find a small Roman font for the licence box rather
than assuming that the application font at 9pt will be useful (which it
probably won't be on non-Roman systems).

[originally from svn r2282]
2002-12-06 00:09:34 +00:00
Ben Harris
a0a3d6fad8 Add some comments explaining what each of these functions is used for.
[originally from svn r2280]
2002-12-04 19:44:57 +00:00
Owen Dunn
269557cb64 Avoid potential memory leak.
[originally from svn r2278]
2002-12-04 12:53:42 +00:00
Simon Tatham
06a8f88e58 #include <signal.h>. Compiled fine without it on Debian 3.0, but not
on 2.2. Wonder what changed.

[originally from svn r2277]
2002-12-04 12:40:36 +00:00
Owen Dunn
cd3252bb66 Changed to use strerror()
[originally from svn r2276]
2002-12-04 12:39:32 +00:00
Ben Harris
c975d75c74 Driver script for building PuTTY under MPW. MPW isn't multi-tasking, so its
"make" program just emits a script for us to run.  This script wraps all that
horribleness up so we don't have to see it.

[originally from svn r2274]
2002-12-02 21:06:12 +00:00