1
0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-10 01:48:00 +00:00
Go to file
Simon Tatham 6f4083e682 Fix double display glitch in erase_lots().
If the cursor is on the rightmost column of the terminal and
term->wrapnext is set, and the user asks to erase from the current
position to the end of (at least) the line, what should happen?

PuTTY's previous behaviour was to ignore term->wrapnext, and do the
same thing we would have done without it: erase from the current
physical cursor position to EOL inclusive, i.e. blank the character
cell we just printed.

But this is unfortunate if a program writes an interleaving of
printing characters and ESC[K, which I recently found out is what gcc
does in its colour-highlighted error messages: if the last printed
char just before an ESC[K pushes the cursor into the deferred-wrap
state, then the ESC[K blanks that character, and then we wrap to the
next line. So one character of the error message ends up missing.

xfce4-terminal and gnome-terminal take the approach in this situation
of regarding the cursor position as _right_ at the end of the line, so
no character cells get cleared at all, and the error message displays
as intended. I think that's more sensible, so I've switched to doing
the same thing.

(xterm has different behaviour again: it blanks the character cell and
also clears its analogue of the wrapnext flag. So in _their_ handling
of this sequence of output, one character of the error message is
still missing, but it looks as if it's been _omitted_ rather than
replaced by a space.)

Secondly, in the course of fixing that, I looked at the check_boundary
call in erase_lots, which is supposed to ensure that if a wide CJK
character straddles the boundary between what's being erased and what
isn't, then both halves of the character are deleted. I had to modify
that anyway because I was moving that very boundary, and in doing so,
I noticed that even according to the previous behaviour, it had an
off-by-one error. In the case where you send ESC[1K (meaning erase up
to and including the cursor position), the call to check_boundary was
performed on the _left_ edge of the cursor's character cell, when it
should have been the right edge. So you could end up with an
erase_char in the left half (i.e. a space) and still have the magic
value UCSWIDE in the right half, causing the terminal to think you had
a double-width U+0020 on the screen, which isn't supposed to be able
to happen.
2019-08-08 18:05:34 +01:00
charset
contrib kh2reg.py: handle OpenSSH hashed hostnames. 2019-04-21 14:46:12 +01:00
doc Update version number for 0.72 release. 2019-07-14 09:51:06 +01:00
icons
test cryptsuite: add a test of rsa_verify. 2019-04-28 10:00:56 +01:00
unix Use sk_namelookup to get FQDN host name. 2019-07-28 15:42:30 +01:00
windows Fix enum_settings_next() to handle subkeys with 256 characters long names. 2019-08-04 15:38:11 +01:00
.gitignore New utility object, StripCtrlChars. 2019-02-20 07:27:22 +00:00
agentf.c
aqsync.c
be_all_s.c
be_all.c
be_misc.c log_proxy_stderr: limit the length of Event Log lines. 2019-03-02 06:54:17 +00:00
be_none.c
be_nos_s.c
be_nossh.c
be_ssh.c
Buildscr Update version number for 0.72 release. 2019-07-14 09:51:06 +01:00
Buildscr.cv Turn off hardware AES for the Coverity build. 2019-05-05 08:38:37 +01:00
callback.c
cgtest.c
CHECKLST.txt Release checklist updates post-0.72. 2019-07-20 08:13:07 +01:00
cmdgen.c cmdgen: add const on main() variable 'comment'. 2019-07-06 18:08:42 +01:00
cmdline.c Switch to using poll(2) in place of select(2). 2019-03-16 12:25:23 +00:00
conf.c
config.c Don't implicitly load a session if Session pane not active. 2019-06-30 15:02:30 +01:00
configure.ac Counterbodge a bodgy warning from 'aclocal'. 2019-03-26 21:19:26 +00:00
cproxy.c
defs.h Make the w32old build warning-clean. 2019-06-19 06:49:24 +01:00
dialog.c New array-growing macros: sgrowarray and sgrowarrayn. 2019-02-28 20:15:38 +00:00
dialog.h Don't implicitly load a session if Session pane not active. 2019-06-30 15:02:30 +01:00
ecc.c
ecc.h
errsock.c Completely remove sk_flush(). 2019-07-28 10:40:47 +01:00
fuzzterm.c Don't implicitly load a session if Session pane not active. 2019-06-30 15:02:30 +01:00
import.c openssh_new_read: fix misaimed null pointer check. 2019-05-05 10:25:01 +01:00
LATEST.VER Update version number for 0.72 release. 2019-07-14 09:51:06 +01:00
ldisc.c Withdraw support for the DECEDM escape sequence. 2019-06-18 06:58:51 +01:00
ldisc.h New array-growing macros: sgrowarray and sgrowarrayn. 2019-02-28 20:15:38 +00:00
LICENCE
licence.pl
logging.c Replace more ad-hoc growing char buffers with strbuf. 2019-02-28 06:42:37 +00:00
mainchan.c mainchan.c: rewrite handling of open-failure aborts. 2019-04-20 09:56:16 +01:00
marshal.c Add BinarySink wrappers on existing forms of output. 2019-02-20 07:27:13 +00:00
marshal.h Add BinarySink wrappers on existing forms of output. 2019-02-20 07:27:13 +00:00
memory.c Check for overflow in the addition in snew_plus(). 2019-07-10 20:47:09 +01:00
minibidi.c Add a per-line 'trusted' status in Terminal. 2019-03-16 12:25:23 +00:00
misc.c Translate more _MSC_VER values in build info. 2019-03-22 07:19:36 +00:00
misc.h Tweak __attribute__((format)) for MinGW. 2019-04-21 13:02:40 +01:00
miscucs.c
mkauto.sh
mkfiles.pl Makefile.clangcl: add .rcpp files to 'make clean'. 2019-06-18 06:55:34 +01:00
mksrcarc.sh Remove all trace of the Inno Setup installer. 2019-03-18 21:53:45 +00:00
mkunxarc.sh
mpint_i.h
mpint.c New mpint function mp_get_integer(). 2019-02-26 07:12:57 +00:00
mpint.h New mpint function mp_get_integer(). 2019-02-26 07:12:57 +00:00
network.h Make proxy_for_destination() static. 2019-07-28 15:42:30 +01:00
nocmdline.c
nocproxy.c
nogss.c
noprint.c
noshare.c
noterm.c
notiming.c
nullplug.c
pageant.c pageant.c: turn a bare 'free' into sfree. 2019-07-06 19:06:49 +01:00
pageant.h
pgssapi.c
pgssapi.h
pinger.c
portfwd.c portfwdmgr_config: null out pointers we're destroying. 2019-03-25 20:49:04 +00:00
pproxy.c
proxy.c Make proxy_for_destination() static. 2019-07-28 15:42:30 +01:00
proxy.h Remove ProxySocket's pending_flush flag. 2019-07-28 11:37:15 +01:00
pscp.c Fall back to not sorting large dirs in pscp -ls or psftp 'ls'. 2019-07-10 20:47:09 +01:00
psftp.c Fall back to not sorting large dirs in pscp -ls or psftp 'ls'. 2019-07-10 20:47:09 +01:00
psftp.h Fall back to not sorting large dirs in pscp -ls or psftp 'ls'. 2019-07-10 20:47:09 +01:00
psftpcommon.c Fall back to not sorting large dirs in pscp -ls or psftp 'ls'. 2019-07-10 20:47:09 +01:00
putty.h Withdraw support for the DECEDM escape sequence. 2019-06-18 06:58:51 +01:00
puttymem.h Check for overflow in the addition in snew_plus(). 2019-07-10 20:47:09 +01:00
puttyps.h
raw.c Seat method to set the current trust status. 2019-03-16 12:25:23 +00:00
README
Recipe Fall back to not sorting large dirs in pscp -ls or psftp 'ls'. 2019-07-10 20:47:09 +01:00
release.pl Remove all trace of the Inno Setup installer. 2019-03-18 21:53:45 +00:00
resource.h
rlogin.c Set trust status appropriately for rlogin. 2019-03-17 13:40:56 +00:00
scpserver.c Add further missing delete_callbacks_for_context. 2019-04-20 08:29:23 +01:00
sercfg.c
sesschan.c Uppity: configurable cwd for session. 2019-04-01 09:06:12 +01:00
sessprep.c sessprep: fix detection of unbracketed IPv6 literals. 2019-03-22 16:32:41 +00:00
settings.c Revert "settings.c: allow load_open_settings(NULL)." 2019-04-13 18:58:25 +01:00
sftp.c fxp_fstat_recv: remove unreachable cleanup code. 2019-05-05 08:38:45 +01:00
sftp.h New array-growing macros: sgrowarray and sgrowarrayn. 2019-02-28 20:15:38 +00:00
sftpcommon.c Fix minor server-triggered DoS in get_fxp_attrs. 2019-07-10 20:47:09 +01:00
sftpserver.c
sign.sh sign.sh: add Windows on Arm builds to the signing list. 2019-03-20 08:00:03 +00:00
ssh1bpp.c Fix integer underflow in SSH-1 BPP. 2019-07-10 20:47:09 +01:00
ssh1censor.c
ssh1connection-client.c SSH-1: disable trust sigils after session starts. 2019-04-20 09:56:16 +01:00
ssh1connection-server.c SSH-1: disable trust sigils after session starts. 2019-04-20 09:56:16 +01:00
ssh1connection.c SSH-1: free mainchan_chan on destruction. 2019-04-20 09:56:16 +01:00
ssh1connection.h SSH-1: disable trust sigils after session starts. 2019-04-20 09:56:16 +01:00
ssh1login-server.c Uppity: configurable list of SSH-1 ciphers to allow. 2019-04-01 20:10:09 +01:00
ssh1login.c Fix too-short buffer in SSH-1 key exchange. 2019-07-10 20:47:09 +01:00
ssh2bpp-bare.c Honour the packet size limit in bare-connection protocol. 2019-07-10 20:35:15 +01:00
ssh2bpp.c Honour the packet size limit in bare-connection protocol. 2019-07-10 20:35:15 +01:00
ssh2censor.c
ssh2connection-client.c Add an interactive anti-spoofing prompt in Plink. 2019-03-16 12:25:23 +00:00
ssh2connection-server.c Pass SshServerConfig through to sesschan.c. 2019-03-31 10:35:10 +01:00
ssh2connection.c Honour the packet size limit in bare-connection protocol. 2019-07-10 20:35:15 +01:00
ssh2connection.h Start of an SSH-server-specific config structure. 2019-03-28 18:29:13 +00:00
ssh2kex-client.c GSS kex: remove spurious no-op assignment. 2019-05-05 10:25:01 +01:00
ssh2kex-server.c Uppity: option to use a pregenerated key for RSA kex. 2019-03-31 21:08:55 +01:00
ssh2transhk.c Add missing del234 in ssh_transient_hostkey_cache_add. 2019-06-15 21:37:36 +01:00
ssh2transport.c Uppity: option to use a pregenerated key for RSA kex. 2019-03-31 21:08:55 +01:00
ssh2transport.h Uppity: option to use a pregenerated key for RSA kex. 2019-03-31 21:08:55 +01:00
ssh2userauth-server.c Uppity: configurable SSH-2 authentication banner. 2019-03-28 18:36:45 +00:00
ssh2userauth.c ssh2userauth: be more careful about s->ki_scc being NULL. 2019-07-23 19:58:48 +01:00
ssh.c mainchan.c: rewrite handling of open-failure aborts. 2019-04-20 09:56:16 +01:00
ssh.h mainchan.c: rewrite handling of open-failure aborts. 2019-04-20 09:56:16 +01:00
sshaes.c Make NEON AES build in 32-bit VS. 2019-04-16 20:47:30 +01:00
ssharcf.c
sshauxcrypt.c
sshbcrypt.c
sshblowf.c
sshblowf.h
sshbpp.h Honour the packet size limit in bare-connection protocol. 2019-07-10 20:35:15 +01:00
sshccp.c Turn ssh2_mac's text_name field into a method. 2019-01-20 17:09:24 +00:00
sshchan.h Remove spurious 'return' in void method wrappers. 2019-04-06 10:12:31 +01:00
sshcommon.c Extra inline helpers seat_{stdout,stderr}_pl. 2019-03-09 16:21:49 +00:00
sshcr.h
sshcrc.c
sshcrcda.c
sshdes.c
sshdh.c
sshdss.c Add missing sanity checks in ssh_dss_verify. 2019-02-10 20:10:41 +00:00
sshdssg.c Rewrite invent_firstbits(). 2019-02-26 07:12:57 +00:00
sshecc.c ecdsa_new_priv_openssh: use correct free function on failure. 2019-06-23 13:52:42 +01:00
sshecdsag.c
sshgss.h
sshgssc.c
sshgssc.h
sshhmac.c Change sensitive strbufs/sgrowarrays to the new _nm version. 2019-03-02 06:54:17 +00:00
sshmac.c
sshmd5.c
sshnogss.c
sshppl.h Start of an SSH-server-specific config structure. 2019-03-28 18:29:13 +00:00
sshprime.c Fix RSA key gen at awkward sizes mod BIGNUM_INT_BITS. 2019-04-17 18:15:23 +01:00
sshprng.c Windows PuTTYgen: bound entropy input by PRNG state size. 2019-02-10 13:44:50 +00:00
sshpubk.c Rename SSH-1 cipher constants to start "SSH1_". 2019-04-01 20:06:42 +01:00
sshrand.c Move random_save_seed() into sshrand.c. 2019-05-05 20:28:00 +01:00
sshrsa.c Fix assertion failure in rsa_verify. 2019-04-28 10:00:46 +01:00
sshrsag.c Fix RSA key gen at awkward sizes mod BIGNUM_INT_BITS. 2019-04-17 18:15:23 +01:00
sshserver.c Uppity: fill in some missing end-of-session handling. 2019-05-10 10:49:20 +01:00
sshserver.h Uppity: option to disallow SSH-1 compression. 2019-04-01 20:17:44 +01:00
sshsh256.c
sshsh512.c
sshsha.c sshsha.c: remove rogue 'got up to here' comment. 2019-04-11 18:21:24 +01:00
sshshare.c Change sensitive strbufs/sgrowarrays to the new _nm version. 2019-03-02 06:54:17 +00:00
sshsignals.h
sshttymodes.h
sshverstring.c Honour the packet size limit in bare-connection protocol. 2019-07-10 20:35:15 +01:00
sshzlib.c Fix a benign buffer overrun in sshzlib.c. 2019-04-28 10:02:23 +01:00
storage.h
stripctrl.c stripctrl: clean up precarious handling of 'width'. 2019-07-23 19:58:48 +01:00
telnet.c Seat method to set the current trust status. 2019-03-16 12:25:23 +00:00
terminal.c Fix double display glitch in erase_lots(). 2019-08-08 18:05:34 +01:00
terminal.h Revert "Bounds-check terminal selection when clearing scrollback." 2019-07-24 18:56:07 +01:00
testback.c Seat method to set the current trust status. 2019-03-16 12:25:23 +00:00
testcrypt.c testcrypt: allow ssh_key constructors to fail. 2019-04-28 10:00:53 +01:00
testcrypt.h testcrypt: allow ssh_key constructors to fail. 2019-04-28 10:00:53 +01:00
testsc.c testsc.c: fix further memory leaks. 2019-05-05 10:25:01 +01:00
testzlib.c
time.c
timing.c
tree234.c
tree234.h
utils.c Avoid using _vsnprintf on MinGW. 2019-04-21 13:00:48 +01:00
version.c
version.h
wcwidth.c
wildcard.c
x11fwd.c

This is the README for the source archive of PuTTY, a free Windows
and Unix Telnet and SSH client.

If you want to rebuild PuTTY from source, we provide a variety of
Makefiles and equivalents. (If you have fetched the source from
Git, you'll have to generate the Makefiles yourself -- see
below.)

There are various compile-time directives that you can use to
disable or modify certain features; it may be necessary to do this
in some environments. They are documented in `Recipe', and in
comments in many of the generated Makefiles.

For building on Windows:

 - windows/Makefile.vc is for command-line builds on MS Visual C++
   systems. Change into the `windows' subdirectory and type `nmake
   -f Makefile.vc' to build all the PuTTY binaries.

   As of 2017, we successfully compile PuTTY with both Visual Studio
   7 (2003) and Visual Studio 14 (2015), so our guess is that it will
   probably build with versions in between those as well.

   (The binaries from Visual Studio 14 are only compatible with
   Windows XP and up. Binaries from Visual Studio 7 ought to work
   with anything from Windows 95 onward.)

 - Inside the windows/MSVC subdirectory are MS Visual Studio project
   files for doing GUI-based builds of the various PuTTY utilities.
   These have been tested on Visual Studio 7 and 10.

   You should be able to build each PuTTY utility by loading the
   corresponding .dsp file in Visual Studio. For example,
   MSVC/putty/putty.dsp builds PuTTY itself, MSVC/plink/plink.dsp
   builds Plink, and so on.

 - windows/Makefile.mgw is for MinGW / Cygwin installations. Type
   `make -f Makefile.mgw' while in the `windows' subdirectory to
   build all the PuTTY binaries.

   MinGW and friends can lag behind other toolchains in their support
   for the Windows API. Compile-time levers are provided to exclude
   some features; the defaults are set appropriately for the
   'mingw-w64' cross-compiler provided with Ubuntu 14.04. If you are
   using an older toolchain, you may need to exclude more features;
   alternatively, you may find that upgrading to a recent version of
   the 'w32api' package helps.

 - windows/Makefile.lcc is for lcc-win32. Type `make -f
   Makefile.lcc' while in the `windows' subdirectory. (You will
   probably need to specify COMPAT=-DNO_MULTIMON.)

 - Inside the windows/DEVCPP subdirectory are Dev-C++ project
   files for doing GUI-based builds of the various PuTTY utilities.

The PuTTY team actively use Makefile.vc (with VC7/10) and Makefile.mgw
(with mingw32), so we'll probably notice problems with those
toolchains fairly quickly. Please report any problems with the other
toolchains mentioned above.

For building on Unix:

 - unix/configure is for Unix and GTK. If you don't have GTK, you
   should still be able to build the command-line utilities (PSCP,
   PSFTP, Plink, PuTTYgen) using this script. To use it, change into
   the `unix' subdirectory, run `./configure' and then `make'. Or you
   can do the same in the top-level directory (we provide a little
   wrapper that invokes configure one level down), which is more like
   a normal Unix source archive but doesn't do so well at keeping the
   per-platform stuff in each platform's subdirectory; it's up to you.

 - unix/Makefile.gtk and unix/Makefile.ux are for non-autoconfigured
   builds. These makefiles expect you to change into the `unix'
   subdirectory, then run `make -f Makefile.gtk' or `make -f
   Makefile.ux' respectively. Makefile.gtk builds all the programs but
   relies on Gtk, whereas Makefile.ux builds only the command-line
   utilities and has no Gtk dependence.

 - For the graphical utilities, any of Gtk+-1.2, Gtk+-2.0, and Gtk+-3.0
   should be supported. If you have more than one installed, you can
   manually specify which one you want by giving the option
   '--with-gtk=N' to the configure script where N is 1, 2, or 3.
   (The default is the newest available, of course.) In the absence
   of any Gtk version, the configure script will automatically
   construct a Makefile which builds only the command-line utilities;
   you can manually create this condition by giving configure the
   option '--without-gtk'.

 - pterm would like to be setuid or setgid, as appropriate, to permit
   it to write records of user logins to /var/run/utmp and
   /var/log/wtmp. (Of course it will not use this privilege for
   anything else, and in particular it will drop all privileges before
   starting up complex subsystems like GTK.) By default the makefile
   will not attempt to add privileges to the pterm executable at 'make
   install' time, but you can ask it to do so by running configure
   with the option '--enable-setuid=USER' or '--enable-setgid=GROUP'.

 - The Unix Makefiles have an `install' target. Note that by default
   it tries to install `man' pages; if you have fetched the source via
   Git then you will need to have built these using Halibut
   first - see below.

 - It's also possible to build the Windows version of PuTTY to run
   on Unix by using Winelib.  To do this, change to the `windows'
   directory and run `make -f Makefile.mgw CC=winegcc RC=wrc'.

All of the Makefiles are generated automatically from the file
`Recipe' by the Perl script `mkfiles.pl' (except for the Unix one,
which is generated by the `configure' script; mkfiles.pl only
generates the input to automake). Additions and corrections to Recipe,
mkfiles.pl and/or configure.ac are much more useful than additions and
corrections to the actual Makefiles, Makefile.am or Makefile.in.

The Unix `configure' script and its various requirements are generated
by the shell script `mkauto.sh', which requires GNU Autoconf, GNU
Automake, and Gtk; if you've got the source from Git rather
than using one of our source snapshots, you'll need to run this
yourself. The input file to Automake is generated by mkfiles.pl along
with all the rest of the makefiles, so you will need to run mkfiles.pl
and then mkauto.sh.

Documentation (in various formats including Windows Help and Unix
`man' pages) is built from the Halibut (`.but') files in the `doc'
subdirectory using `doc/Makefile'. If you aren't using one of our
source snapshots, you'll need to do this yourself. Halibut can be
found at <https://www.chiark.greenend.org.uk/~sgtatham/halibut/>.

The PuTTY home web site is

    https://www.chiark.greenend.org.uk/~sgtatham/putty/

If you want to send bug reports or feature requests, please read the
Feedback section of the web site before doing so. Sending one-line
reports saying `it doesn't work' will waste your time as much as
ours.

See the file LICENCE for the licence conditions.