f7d05e2ffa
Add feature flags constants and flag new route
2023-10-02 08:27:24 +10:00
fbb7aa1350
[AC-1666] Removed EditAnyCollection from Create/Delete permission checks ( #3301 )
...
* fix: remove EditAnyCollection from Create/Delete permission check, refs AC-1666
* fix: updated comment, refs AC-1666
2023-09-28 20:32:52 -05:00
dd1061493c
Merge branch 'master' into feature/flexible-collections
2023-09-29 09:23:47 +10:00
3e90f57797
[DEVOPS-1519] Add transition mode to mssql migrator utility ( #3259 )
...
* Add RerunableSqlTableJournal
* Add extension to use rerunable sql table journal
* Use rerunable sql journal
* format
* Enable logging
* FIx
* Disable logging
* Rename to SqlTableJournalExtensions
* Move RerunableSqlTableJournal to Extension class
* Fix usings
* Add rerunable schema
* Format
* Fix typo
* Enable logging in db migrator
* add rerunable column in dbo migrations table migration
* Trying
* Fix journal table name
* Trying to migrate first
* After migration
* Testing
* Add update from rerunable to not rerunable script
* Change name
* Add rerunable option and script folder name
* Add rerunable options and folder
* Fix
* Add transition (aka rerunable) migrations to Setup
* Parse parameters on migrator utility
* Fix sql scripts
* Remove CreateSchemaTableSql as it'll be migrated using migration
* Embed dbScripts_data_migration folder
* Remove testing sql script
* Add optins parsing nuget for msSqlMigratorUtility
* Fix sql journal
* Ran dotnet format
* Comment out index
* ▫️ Revert "Comment out index"
This reverts commit df15fa91e0
2023-09-28 16:29:52 +02:00
7ede956c32
Individual Vault Item Encryption Feature ( #3256 )
...
* [SG-966] [SG-967] Add new cipher properties, update DB objects and create migrations (#2681 )
* Updated cipher entity with two new columns
* Added sqlserver mifgration and updated applicable stored procedures and table
* Added EF Migrations
* Made changes to response model to include new column properties
* Fixed formatting
* Modified scripts to reflect suggestions made on PR
* Added column to cipher table using default
* Include constraint in create cipher table script
* Added key and forcerotatekey property to request model (#2716 )
* Added key update on the Cipher_UpdateWithCollection stored procedure, ef (#2855 )
* Added key and forceKeyRotation to BuildCiphersTable method (#2893 )
* [PM-2211] Remove forceKeyRotation column (#2921 )
* Removed forceKeyRotation column
* Adjusted date for migrtaion file
* Passed key column to update cipher script to update cipher key when it is rotated (#2967 )
* [PM-2448] Update CipherDetails_Update SP to update attachment column (#2992 )
* Updated the cipherdetails_update stored procedure to update the attachement column when encrypted with the cipher key
* Moved migration and renamed old migration file
* Fixed lint issues
* Fixed lint issues
* renamed sqlserver migration to have a more recent date
* [PM-2548] Added validation to edit and add attachments methods (#3130 )
* PM-2548 Added validation to edit and add attachments methods
* PM-2548 Moved the validation to a private method
* PM-2548 Minor refactor
* Bumped up minimum version
* Bumped up minimum version
* Changed version for tests purposes
* Bumped up minimum version
* Updated encryption minimum version to match clients for QA.
* PM-3976 Passed Key column to update cipher on bulk edit (#3299 )
* Updated minimum client version in preparation for release.
* Renamed migration with current date. (#3303 )
---------
Co-authored-by: SmithThe4th <gsmith@bitwarden.com >
Co-authored-by: gbubemismith <gsmithwalter@gmail.com >
Co-authored-by: Carlos Gonçalves <cgoncalves@bitwarden.com >
Co-authored-by: Carlos Gonçalves <carlosmaccam@gmail.com >
2023-09-28 08:45:13 -04:00
30b91cd1a2
Merge branch 'master' into feature/flexible-collections
2023-09-27 11:26:06 +10:00
a3f554a34e
[AC-1646] Rename LimitCollectionCdOwnerAdmin column ( #3300 )
...
* Rename LimitCollectionCdOwnerAdmin -> LimitCollectionCreationDeletion
* Rename and bump migration script
2023-09-27 07:37:34 +10:00
5d431adbd4
[AC-1174] Bulk Collection Management ( #3229 )
...
* [AC-1174] Update SelectionReadOnlyRequestModel to use Guid for Id property
* [AC-1174] Introduce initial bulk-access collection endpoint
* [AC-1174] Introduce BulkAddCollectionAccessCommand and validation logic/tests
* [AC-1174] Add CreateOrUpdateAccessMany method to CollectionRepository
* [AC-1174] Add event logs for bulk add collection access command
* [AC-1174] Add User_BumpAccountRevisionDateByCollectionIds and database migration script
* [AC-1174] Implement EF repository method
* [AC-1174] Improve null checks
* [AC-1174] Remove unnecessary BulkCollectionAccessRequestModel helpers
* [AC-1174] Add unit tests for new controller endpoint
* [AC-1174] Fix formatting
* [AC-1174] Remove comment
* [AC-1174] Remove redundant organizationId parameter
* [AC-1174] Ensure user and group Ids are distinct
* [AC-1174] Cleanup tests based on PR feedback
* [AC-1174] Formatting
* [AC-1174] Update CollectionGroup alias in the sproc
* [AC-1174] Add some additional comments to SQL sproc
* [AC-1174] Add comment explaining additional SaveChangesAsync call
---------
Co-authored-by: Thomas Rittson <trittson@bitwarden.com >
2023-09-26 09:30:07 -07:00
464dac8f4d
Update bitwarden/gh-actions digest to fdcf1fc ( #3230 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-09-26 10:30:28 -04:00
2c7d02dcbb
Merge branch 'master' into feature/flexible-collections
2023-09-26 10:40:26 +10:00
9db1007df6
Only log errors with LaunchDarkly ( #3298 )
2023-09-25 15:32:06 -04:00
0b72eb8e45
Admin: Update Stripe Customer Email on Organization Edit ( #3281 )
...
* Admin: Update Stripe customer email on organization billing email update
* Conner's feedback
2023-09-25 10:16:19 -04:00
44baba9229
[PM-4075] Setup Feature Flag for Browser Fileless Import ( #3296 )
2023-09-25 13:16:21 +00:00
e3dc515062
Update actions/checkout action to v4.1.0 ( #3293 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-09-25 08:34:54 -04:00
bfe71e5056
Delete NuGet config ( #3290 )
2023-09-22 11:18:59 -04:00
46faecaade
[SM-755] Add EF Secrets Manager cleanup on deletes ( #3228 )
...
* Add Delete Cascade for EF AccessPolicy table
* Add AP removal on EF user deletion
* Remove SM entities on EF org delete
2023-09-21 17:22:08 -05:00
90d600db9d
[PM-2961] Upgrade Braintree ( #3206 )
...
* Upgraded Braintree to 5.19.0
* Force evaluate of nuget packages
---------
Co-authored-by: cyprain-okeke <108260115+cyprain-okeke@users.noreply.github.com >
2023-09-20 14:11:29 -04:00
f2acf1c366
refactor: remove organizationId from CollectionBulkDeleteRequestModel, refs AC-1649 ( #3282 )
2023-09-20 13:07:58 -05:00
0af5eaec7d
Remove sm-ga-billing feature flag ( #3254 )
2023-09-20 09:36:36 +10:00
ffa09d105e
Merge branch 'master' into feature/flexible-collections
2023-09-19 15:30:07 -05:00
f29a142c80
Bumped version to 2023.9.0 ( #3280 )
...
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com >
2023-09-19 09:49:25 -04:00
9f5fec67a0
Merge remote-tracking branch 'origin/master' into feature/flexible-collections
2023-09-19 13:12:59 +10:00
2149266199
Migration to remove WebAuthn 2FA method from Free users ( #3271 )
...
* Created migration for review.
* Added in check for org users that have Premium through their org.
* Commented out UPDATE for testing.
* Changes from PR Review
* Added U2F handling.
* Address PR feedback
* Updated to use string for type comparision due to bad data in Prod database.
* Added revision date to update and uncommented update for migration run.
2023-09-18 18:36:26 -04:00
34dfdc53aa
[AC-1125] Enforce org setting for creating/deleting collections ( #3241 )
...
* [AC-1117] Add manage permission (#3126 )
* Update sql files to add Manage permission
* Add migration script
* Rename collection manage migration file to remove duplicate migration date
* Migrations
* Add manage to models
* Add manage to repository
* Add constraint to Manage columns
* Migration lint fixes
* Add manage to OrganizationUserUserDetails_ReadWithCollectionsById
* Add missing manage fields
* Add 'Manage' to UserCollectionDetails
* Use CREATE OR ALTER where possible
* [AC-1374] Limit collection creation/deletion to Owner/Admin (#3145 )
* feat: update org table with new column, write migration, refs AC-1374
* feat: update views with new column, refs AC-1374
* feat: Alter sprocs (org create/update) to include new column, refs AC-1374
* feat: update entity/data/request/response models to handle new column, refs AC-1374
* feat: update necessary Provider related views during migration, refs AC-1374
* fix: update org create to default new column to false, refs AC-1374
* feat: added new API/request model for collection management and removed property from update request model, refs AC-1374
* fix: renamed migration script to be after secrets manage beta column changes, refs AC-1374
* fix: dotnet format, refs AC-1374
* feat: add ef migrations to reflect mssql changes, refs AC-1374
* fix: dotnet format, refs AC-1374
* feat: update API signature to accept Guid and explain Cd verbiage, refs AC-1374
* feat: created collection auth handler/operations, added LimitCollectionCdOwnerAdmin to CurrentContentOrganization, refs AC-1125
* feat: create vault service collection extensions and register with base services, refs AC-1125
* feat: deprecated CurrentContext.CreateNewCollections, refs AC-1125
* feat: deprecate DeleteAnyCollection for single resource usages, refs AC-1125
* feat: move service registration to api, update references, refs AC-1125
* feat: add bulk delete authorization handler, refs AC-1125
* feat: always assign user and give manage access on create, refs AC-1125
* fix: updated CurrentContextOrganization type, refs AC-1125
* feat: combined existing collection authorization handlers/operations, refs AC-1125
* fix: OrganizationServiceTests -> CurrentContentOrganization typo, refs AC-1125
* fix: format, refs AC-1125
* fix: update collection controller tests, refs AC-1125
* fix: dotnet format, refs AC-1125
* feat: removed extra BulkAuthorizationHandler, refs AC-1125
* fix: dotnet format, refs AC-1125
* fix: change string to guid for org id, update bulk delete request model, refs AC-1125
* fix: remove delete many collection check, refs AC-1125
* fix: clean up collection auth handler, refs AC-1125
* fix: format fix for CollectionOperations, refs AC-1125
* fix: removed unnecessary owner check, add org null check to custom permission validation, refs AC-1125
* fix: remove unused methods in CurrentContext, refs AC-1125
* fix: removed obsolete test, fixed failling delete many test, refs AC-1125
* fix: CollectionAuthorizationHandlerTests fixes, refs AC-1125
* fix: OrganizationServiceTests fix broken test by mocking GetOrganization, refs AC-1125
* fix: CollectionAuthorizationHandler - remove unused repository, refs AC-1125
* feat: moved UserId null check to common method, refs AC-1125
* fix: updated auth handler tests to remove dependency on requirement for common code checks, refs AC-1125
* feat: updated conditionals/comments for create/delete methods within colleciton auth handler, refs AC-1125
* feat: added create/delete collection auth handler success methods, refs AC-1125
* fix: new up permissions to prevent excessive null checks, refs AC-1125
* fix: remove old reference to CreateNewCollections, refs AC-1125
* fix: typo within ViewAssignedCollections method, refs AC-1125
---------
Co-authored-by: Robyn MacCallum <robyntmaccallum@gmail.com >
2023-09-18 17:02:53 -05:00
4100372401
Update actions/checkout action to v4 ( #3257 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-09-18 10:47:07 -04:00
876274b39e
Update gh minor ( #3077 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-09-18 10:39:38 -04:00
cd0f8ce411
only tracking TOTPs in cache ( #3275 )
2023-09-15 13:38:56 -07:00
8b30b3c7fd
Refresh lockfiles ( #3274 )
2023-09-15 15:49:34 -04:00
227178980a
PM-3925 - Tech Debt - Add missed tests for SSO Email 2FA Tokenable ( #3270 )
...
* PM-3925 - (1) Slightly refactor SsoEmail2faSessionTokenable to provide public static GetTokenLifeTime() method for testing (2) Add missed tests to SsoEmail2faSessionTokenable
* PM-3925 - Take into account PR feedback
2023-09-15 14:54:52 -04:00
c08a48cd19
Bump SignalR Redis Package ( #3272 )
2023-09-15 09:56:21 -04:00
1fcf070765
Setup secrets, use switch instead of bool ( #3269 )
2023-09-14 14:39:13 +02:00
f080763b6c
Add -legacy flag to openssl invocations ( #3265 )
2023-09-13 15:17:19 -04:00
acd3997133
Merge branch 'master' into feature/flexible-collections
2023-09-13 11:04:59 -05:00
d3aceea377
no longer cache remember me token ( #3267 )
2023-09-13 09:08:25 -04:00
b6d32129e6
made cache key more unique ( #3266 )
2023-09-12 13:39:14 -07:00
064a28c325
fix: add permission check for collection management api, refs AC-1647 ( #3252 )
2023-09-12 10:35:25 -05:00
4ac1b10fb1
Merge branch 'master' into feature/flexible-collections
2023-09-12 10:32:23 -05:00
0be766c98a
Manually move data migration scripts ( #3264 )
2023-09-12 07:34:50 -07:00
f909563211
[PM-3487] prevent account enumeration on auth request endpoint ( #3239 )
2023-09-11 10:23:32 -04:00
917c657439
PM-2128 Enforce one time use of TOTP ( #3152 )
...
* enforcing one time MFA token use
* Updated cache TTL
* renamed the cache
* removed IP limit, added comment, updated cache Key
* fixed build errors
2023-09-09 17:35:08 -04:00
4b482f0a34
[SM-918] Enforce project maximums on import ( #3253 )
...
* Refactor MaxProjectsQuery for multiple adds
* Update unit tests
* Add max project enforcement to imports
2023-09-07 17:51:35 -05:00
2aaef3cf64
[PM-289] Add taxIdType for more countries in TaxInfo ( #3186 )
...
* Add taxIdType for more countries in TaxInfo
* Removed Afghanistan tax ID
* Normalize country code in tax info model
2023-09-07 16:54:56 +00:00
b8b2efa767
Remove indexing from data migration ( #3247 )
2023-09-07 11:33:46 -05:00
721c18e94a
[AC-244] Consider a user's email as verified when they accept an organization invitation via the email link ( #3199 )
...
* [AC-244] Saving User.EmailVerified = true when accepting organization invite
* [AC-244] Added unit tests
* [AC-244] Added the parameter 'verifyEmail' to OrganizationService.AcceptUserAsync
* [AC-244] Refactored unit tests
* [AC-244] Fixed failing unit tests
* [AC-244] Marking email as verified only in the endpoint for accepting an invite with a token
* Update src/Core/Services/IOrganizationService.cs
Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com >
* [AC-244] Marking email as verified only if it was not
* [AC-244] Updated unit test to have the user's email unverified at the start
* [AC-244] dotnet format
---------
Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com >
Co-authored-by: Vincent Salucci <vincesalucci21@gmail.com >
2023-09-07 14:36:54 +01:00
8c75326439
[AC-1612] Updated CurrentContext.ViewAssignedCollections to check if the user has CreateNewCollections permission ( #3233 )
...
* [AC-1612] Updated CurrentContext.ViewAssignedCollections to check if the user has CreateNewCollections permission
* [AC-1612] Added comment to clarify the requirement of the added check in ViewAssignedCollections
2023-09-07 10:42:04 +01:00
952e77d3d7
Update kenchan0130/simplesamlphp Docker tag to v1.19.8 ( #3060 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-09-05 14:57:29 -06:00
798fca51e2
Bumped version to 2023.8.3 ( #3249 )
...
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com >
2023-09-05 16:53:30 -04:00
3c9c8acc22
Merge remote-tracking branch 'origin/master' into feature/flexible-collections
2023-09-05 06:33:10 +10:00
4d0630081a
Fix flaky OrganizationService tests ( #3246 )
...
Set up test data more explicitly instead of relying on AutoData
2023-09-05 06:32:47 +10:00
9eed199500
Pm 3504 saml ( #3235 )
...
* return early if scheme doesn't match
* Revert "return early if scheme doesn't match"
This reverts commit 5c07d66774
2023-09-01 13:55:52 -04:00
